2.x: more detailed no-multi-subscribe with std consumers error message#5301
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom Apr 20, 2017
Merged
2.x: more detailed no-multi-subscribe with std consumers error message#5301akarnokd merged 2 commits intoReactiveX:2.xfrom
akarnokd merged 2 commits intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5301 +/- ##
============================================
- Coverage 96.17% 96.09% -0.09%
- Complexity 5756 5774 +18
============================================
Files 628 630 +2
Lines 41085 41148 +63
Branches 5703 5714 +11
============================================
+ Hits 39514 39540 +26
- Misses 613 638 +25
- Partials 958 970 +12
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Apr 20, 2017
Contributor
JakeWharton
left a comment
There was a problem hiding this comment.
Reviewed on mobile. I tried my best.
Member
Author
|
Thanks Jake. We can refine the message later if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the "Disposable already set!" and "Subscription already set!" messages on the standard consumer classes (
DisposableSubscriber,DisposableObserver, etc.) to something more meaningful:"It is not allowed to subscribe with a(n)
<class name>multiple times. Please create a fresh instance of<class name>and subscribe that to the target source instead."Where
<class name>is a placeholder for thegetClass().getName()of the subclass of those consumer types. It should clearly state to avoid subscribing with them multiple times as well as printing the full class name to indicate the problem is with the use of the implementor class, and not with the abstract RxJava class.Inspired by this StackOverflow question, one of many such questions.
For the internal operators, the original error message stays because when they appear, that is still likely due to an implementation bug (or a misbehaving user-created custom implementation).