Merged
Conversation
The note was claiming Observable.doOnDispose() would be called for terminal events of the Observable, which is not the case
akarnokd
approved these changes
Apr 19, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5296 +/- ##
============================================
+ Coverage 96.11% 96.26% +0.15%
- Complexity 5750 5767 +17
============================================
Files 628 628
Lines 41085 41085
Branches 5703 5703
============================================
+ Hits 39487 39551 +64
+ Misses 634 600 -34
+ Partials 964 934 -30
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the earlier PR #5295... :/
This addresses the JavaDoc issues discussed in #5283.
Observable.doOnDisposewhich claims its action would be called on terminal events.Maybe/Single/Completablevariants.@throwsnote to someObservable/Single/Maybe.doOnDisposeas it was present in theCompletablevariant.