2.x: Single.subscribe(BiConsumer) consistent isDisposed#5277
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Apr 10, 2017
Merged
2.x: Single.subscribe(BiConsumer) consistent isDisposed#5277akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
vanniktech
approved these changes
Apr 10, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5277 +/- ##
============================================
+ Coverage 96.02% 96.11% +0.08%
- Complexity 5752 5754 +2
============================================
Files 628 628
Lines 41077 41079 +2
Branches 5699 5699
============================================
+ Hits 39445 39482 +37
+ Misses 658 627 -31
+ Partials 974 970 -4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
Single.subscribe(BiConsumer)to reportisDisposedwhen terminating.Reported in #5276.