2.x: fix flatMapIterable appearing to be empty when fused#5256
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Apr 1, 2017
Merged
2.x: fix flatMapIterable appearing to be empty when fused#5256akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5256 +/- ##
============================================
+ Coverage 95.95% 95.99% +0.04%
+ Complexity 5750 5746 -4
============================================
Files 628 628
Lines 41075 41077 +2
Branches 5698 5699 +1
============================================
+ Hits 39414 39433 +19
+ Misses 664 657 -7
+ Partials 997 987 -10
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Apr 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrong logical expression in the
isEmpty()method madeflatMapIterablecomplete earlier, even if data was available in the current iterable.Somewhat related: reactor/reactor-core#508 (different logical bug in the same method).