2.x: fix CallbackCompletableObserver calling onError, ResourceX wording#5240
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 27, 2017
Merged
2.x: fix CallbackCompletableObserver calling onError, ResourceX wording#5240akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5240 +/- ##
============================================
+ Coverage 96.12% 96.15% +0.02%
- Complexity 5757 5758 +1
============================================
Files 628 628
Lines 41074 41073 -1
Branches 5697 5697
============================================
+ Hits 39484 39495 +11
+ Misses 630 616 -14
- Partials 960 962 +2
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Mar 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the fix for incorrect call of the
onErrorhandler withinCallbackCompletableObserver.onComplete()reported in 5099 as well as wording fixes to theResourceXjavadoc.