2.x: fix window() with time+size emission problems#5213
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 22, 2017
Merged
2.x: fix window() with time+size emission problems#5213akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
d3936da to
158cb0d
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #5213 +/- ##
============================================
+ Coverage 96.02% 96.12% +0.09%
- Complexity 5680 5690 +10
============================================
Files 621 621
Lines 40611 40617 +6
Branches 5632 5636 +4
============================================
+ Hits 38998 39042 +44
+ Misses 643 623 -20
+ Partials 970 952 -18
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Mar 22, 2017
JakeWharton
approved these changes
Mar 22, 2017
mostroverkhov
pushed a commit
to mostroverkhov/RxJava
that referenced
this pull request
Mar 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
window()operator overload with time and size bound didn't work correctly when some windows were terminated by the timeout and others by the size. This PR fixes:Related #5104 (again).