2.x: better documentation on the abstract consumer classes#5210
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 21, 2017
Merged
2.x: better documentation on the abstract consumer classes#5210akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
This was referenced Mar 21, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5210 +/- ##
===========================================
+ Coverage 95.9% 96.01% +0.11%
- Complexity 5678 5684 +6
===========================================
Files 621 621
Lines 40611 40611
Branches 5632 5632
===========================================
+ Hits 38947 38992 +45
+ Misses 673 644 -29
+ Partials 991 975 -16
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Mar 21, 2017
JakeWharton
approved these changes
Mar 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the documentation of the abstract consumer classes such as
DisposableSubscriber,ResourceSubscriberand their counterparts for the other base reactive types.It contains a lot of copy-paste so please read through all of the text in case the text was not properly adapted to the abstract class at hand.
Related: #5148.