2.x: fix images of firstElement, flattenAsX, flatMapIterable#5208
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom Mar 21, 2017
Merged
2.x: fix images of firstElement, flattenAsX, flatMapIterable#5208akarnokd merged 2 commits intoReactiveX:2.xfrom
akarnokd merged 2 commits intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5208 +/- ##
===========================================
- Coverage 95.9% 95.88% -0.02%
+ Complexity 5678 5672 -6
===========================================
Files 621 621
Lines 40611 40611
Branches 5632 5632
===========================================
- Hits 38947 38941 -6
+ Misses 673 671 -2
- Partials 991 999 +8
Continue to review full report at Codecov.
|
Member
Author
vanniktech
approved these changes
Mar 21, 2017
Collaborator
vanniktech
left a comment
There was a problem hiding this comment.
Those height & width resizes are due to the new images, right?
Member
Author
|
Yes, the default with is set to 640 and these new images are slightly bigger in their native form. |
Member
Author
|
Thanks for the reviews guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR links in the new images from #5130 for previously misleading marble diagrams of the operators.