2.x: prevent tasks to self interrupt on the standard schedulers#5207
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 22, 2017
Merged
2.x: prevent tasks to self interrupt on the standard schedulers#5207akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
This was referenced Mar 20, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5207 +/- ##
===========================================
+ Coverage 95.9% 95.95% +0.05%
- Complexity 5678 5706 +28
===========================================
Files 621 624 +3
Lines 40611 40677 +66
Branches 5632 5644 +12
===========================================
+ Hits 38947 39032 +85
+ Misses 673 660 -13
+ Partials 991 985 -6
Continue to review full report at Codecov.
|
c0f9a80 to
80dcb69
Compare
vanniktech
approved these changes
Mar 22, 2017
Collaborator
vanniktech
left a comment
There was a problem hiding this comment.
👍 didn't quite understand everything but the tests seem good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task wrappers of the various schedulers and modes (direct & worker) were able to get cancelled via interruption from the same thread they were running.
Related #5203.