Skip to content

Correct java doc for refCount() return type. v2.0.7#5191

Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom
sadegh:sk/doc-fix
Mar 16, 2017
Merged

Correct java doc for refCount() return type. v2.0.7#5191
akarnokd merged 1 commit intoReactiveX:2.xfrom
sadegh:sk/doc-fix

Conversation

@sadegh
Copy link
Contributor

@sadegh sadegh commented Mar 16, 2017

Java doc for ConnectableObservable.refCount() says it returns a Flowable, but it should be Observable

@sadegh sadegh changed the title Correct java doc for refCount() return type. - v2.0.7 Correct java doc for refCount() return type. v2.0.7 Mar 16, 2017
@codecov
Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #5191 into 2.x will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #5191      +/-   ##
============================================
+ Coverage     95.93%   95.96%   +0.02%     
- Complexity     5667     5679      +12     
============================================
  Files           621      621              
  Lines         40611    40611              
  Branches       5632     5632              
============================================
+ Hits          38960    38971      +11     
+ Misses          663      658       -5     
+ Partials        988      982       -6
Impacted Files Coverage Δ Complexity Δ
...o/reactivex/observables/ConnectableObservable.java 100% <ø> (ø) 7 <0> (ø)
...al/operators/observable/ObservableSampleTimed.java 88.33% <0%> (-8.34%) 3% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 83.93% <0%> (-6.74%) 55% <0%> (-1%)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...ex/internal/operators/maybe/MaybeTimeoutMaybe.java 94.11% <0%> (-4.42%) 2% <0%> (ø)
...reactivex/internal/operators/maybe/MaybeUsing.java 93.93% <0%> (-4.05%) 4% <0%> (ø)
...vex/internal/operators/flowable/FlowableTimer.java 92.85% <0%> (-3.58%) 2% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 93.39% <0%> (-2.21%) 10% <0%> (ø)
.../internal/operators/maybe/MaybeTakeUntilMaybe.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
...activex/internal/disposables/DisposableHelper.java 98.14% <0%> (-1.86%) 27% <0%> (-1%)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7673c09...b181a2d. Read the comment docs.

@akarnokd akarnokd added this to the 2.0 backlog milestone Mar 16, 2017
Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it to an {@link Observable}?

* is at least one subscription to this {@code ConnectableObservable}.
*
* @return a {@link Flowable}
* @return a {@link Observable}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an

@sadegh
Copy link
Contributor Author

sadegh commented Mar 16, 2017

fixed!

@akarnokd akarnokd merged commit 7265d33 into ReactiveX:2.x Mar 16, 2017
@akarnokd
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants