Correct java doc for refCount() return type. v2.0.7#5191
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 16, 2017
sadegh:sk/doc-fix
Merged
Correct java doc for refCount() return type. v2.0.7#5191akarnokd merged 1 commit intoReactiveX:2.xfrom sadegh:sk/doc-fix
akarnokd merged 1 commit intoReactiveX:2.xfrom
sadegh:sk/doc-fix
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5191 +/- ##
============================================
+ Coverage 95.93% 95.96% +0.02%
- Complexity 5667 5679 +12
============================================
Files 621 621
Lines 40611 40611
Branches 5632 5632
============================================
+ Hits 38960 38971 +11
+ Misses 663 658 -5
+ Partials 988 982 -6
Continue to review full report at Codecov.
|
akarnokd
reviewed
Mar 16, 2017
Member
akarnokd
left a comment
There was a problem hiding this comment.
Could you change it to an {@link Observable}?
| * is at least one subscription to this {@code ConnectableObservable}. | ||
| * | ||
| * @return a {@link Flowable} | ||
| * @return a {@link Observable} |
Contributor
Author
|
fixed! |
akarnokd
approved these changes
Mar 16, 2017
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java doc for
ConnectableObservable.refCount()says it returns aFlowable, but it should beObservable