2.x: reflection-based parameter validator & fixes#5187
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 15, 2017
Merged
2.x: reflection-based parameter validator & fixes#5187akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5187 +/- ##
============================================
+ Coverage 95.98% 96.04% +0.05%
- Complexity 5665 5673 +8
============================================
Files 621 621
Lines 40340 40581 +241
Branches 5616 5620 +4
============================================
+ Hits 38722 38975 +253
- Misses 638 641 +3
+ Partials 980 965 -15
Continue to review full report at Codecov.
|
Member
Author
|
Thanks @vanniktech ! I'm merging this because there are a couple of inbound API changes from other contributors and having this in place avoids conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a reflection-based parameter validator to check the base reactive classes for proper parameter validation: null checks and argument ranges. The problems detected are fixed as well.