2.x: fix LambdaObserver not cancelling the upstream#5170
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 10, 2017
Merged
2.x: fix LambdaObserver not cancelling the upstream#5170akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5170 +/- ##
============================================
- Coverage 95.94% 95.94% -0.01%
+ Complexity 5658 5656 -2
============================================
Files 621 621
Lines 39972 39974 +2
Branches 5610 5610
============================================
Hits 38352 38352
+ Misses 643 642 -1
- Partials 977 980 +3
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Mar 10, 2017
JakeWharton
approved these changes
Mar 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LambdaObserverdidn't cancel the upstream when itsonSubscribeandonNextcallbacks crashed. Also reported on the mailing list:The
LambdaSubscriberwas working correctly. Both received unit tests to ensure the correct behavior.