Add @NonNull to the methods of Emitter#5156
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 5, 2017
Merged
Conversation
Contributor
Author
|
Sorry, I've just noticed there is #5151 related to this PR. |
Codecov Report
@@ Coverage Diff @@
## 2.x #5156 +/- ##
============================================
+ Coverage 95.88% 95.91% +0.02%
+ Complexity 5606 5601 -5
============================================
Files 620 620
Lines 39856 39856
Branches 5604 5604
============================================
+ Hits 38217 38227 +10
+ Misses 654 651 -3
+ Partials 985 978 -7
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Mar 5, 2017
Member
|
Thanks @hkurokawa for the PR and @vanniktech for the review! |
Contributor
Author
|
@vanniktech @akarnokd Thank you for your prompt merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of #4876
This PR adds
@NonNullannotation to some methods ofEmitterso that the users of RxJava migrating from 1.x to 2.x can easily know passing null to the methods will cause NPE.