2.x: fix timed replay-like components replaying outdated items#5140
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Feb 27, 2017
Merged
2.x: fix timed replay-like components replaying outdated items#5140akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5140 +/- ##
============================================
- Coverage 95.96% 95.96% -0.01%
+ Complexity 5611 5601 -10
============================================
Files 620 620
Lines 39820 39850 +30
Branches 5599 5603 +4
============================================
+ Hits 38215 38242 +27
Misses 633 633
- Partials 972 975 +3
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Feb 27, 2017
This was referenced Feb 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timed versions of
Flowable.replay(),ReplayProcessor,Observable.replay()andReplaySubjectall replay outdated items to new subscribers and through thegetValues()andsize()state-peeking methods, similar to issue #3917 resolved via #4023.The fix includes a node-walk for new subscribers that skips old entries. Some unit tests weren't logically considering the emission pattern (i.e., items timed out shouldn't appear) and have been fixed as well.
Reported in #5139.