Skip to content

2.x: fix repeatWhen and retryWhen signatures#5136

Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd:XWhenSignature
Feb 25, 2017
Merged

2.x: fix repeatWhen and retryWhen signatures#5136
akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd:XWhenSignature

Conversation

@akarnokd
Copy link
Member

Adjust the repeatWhen and retryWhen signatures to accept Publisher<?> on Single and Completable, matching Flowable's signature.

Reported in #5135.

@codecov
Copy link

codecov bot commented Feb 25, 2017

Codecov Report

❗ No coverage uploaded for pull request base (2.x@2a4b18e). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             2.x    #5136   +/-   ##
======================================
  Coverage       ?   95.81%           
  Complexity     ?     5601           
======================================
  Files          ?      620           
  Lines          ?    39820           
  Branches       ?     5599           
======================================
  Hits           ?    38154           
  Misses         ?      672           
  Partials       ?      994
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 522 <ø> (?)
src/main/java/io/reactivex/Single.java 99.29% <ø> (ø) 131 <ø> (?)
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 112 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4b18e...d7bd221. Read the comment docs.

@akarnokd akarnokd merged commit a03bf90 into ReactiveX:2.x Feb 25, 2017
@akarnokd akarnokd deleted the XWhenSignature branch February 25, 2017 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants