2.x: fix flatMap not cancelling the upstream eagerly#5133
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Feb 24, 2017
Merged
2.x: fix flatMap not cancelling the upstream eagerly#5133akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5133 +/- ##
============================================
+ Coverage 95.92% 95.94% +0.02%
+ Complexity 5608 5601 -7
============================================
Files 620 620
Lines 39810 39820 +10
Branches 5597 5599 +2
============================================
+ Hits 38186 38207 +21
+ Misses 651 640 -11
Partials 973 973
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Feb 24, 2017
This was referenced Feb 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the lack of eager cancellation when flatmapping sources and not stopping the upstream if the inner source fails.
Unit tests were added to verify
Single(in case it receives a dedicated implementation one day as currently it delegates toFlowable),FlowableandObservable.Reported in #5132.