1.x: throttleFirst detecting clock-drift backwards to open the gate#5123
Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom Feb 22, 2017
Merged
1.x: throttleFirst detecting clock-drift backwards to open the gate#5123akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd merged 1 commit intoReactiveX:1.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #5123 +/- ##
============================================
+ Coverage 84.38% 84.41% +0.02%
- Complexity 2876 2877 +1
============================================
Files 290 290
Lines 18070 18070
Branches 2468 2468
============================================
+ Hits 15249 15254 +5
- Misses 1951 1954 +3
+ Partials 870 862 -8
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Feb 21, 2017
davidmoten
approved these changes
Feb 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the current time moves backwards before the time the gate was closed, the opening of the gate would happen way later. Since we don't know how much relative time has passed, this fix opens the gate when the drift is detected during
onNext.Reported in #5120.
/cc @davidmoten as you've been experimenting with time-only (that is non-scheduled) gating.