2.x: fix doOnSubscribe signalling Undeliv.Exception instead of just onError#5103
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Feb 16, 2017
Merged
2.x: fix doOnSubscribe signalling Undeliv.Exception instead of just onError#5103akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5103 +/- ##
===========================================
- Coverage 95.61% 95.6% -0.01%
- Complexity 5554 5562 +8
===========================================
Files 615 615
Lines 39685 39703 +18
Branches 5578 5583 +5
===========================================
+ Hits 37944 37959 +15
- Misses 757 762 +5
+ Partials 984 982 -2
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Feb 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported on StackOverflow where crashing the lambda in
Flowable.doOnSubscribecalls theRxJavaPlugins.onError, which crashes the app and prevents calling theEmptySubscription.erroron Android. (Desktop prints to the console and delivers the error normally.)The bug was present in the
Flowable,ObservableandCompletable. All 5 base types received the respective unit test to ensure correct behavior.