1.x: add Single.merge(Obs), Obs.flatMapSingle & flatMapCompletable#5092
Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom Feb 11, 2017
Merged
1.x: add Single.merge(Obs), Obs.flatMapSingle & flatMapCompletable#5092akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd merged 1 commit intoReactiveX:1.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #5092 +/- ##
============================================
+ Coverage 84.12% 84.29% +0.17%
- Complexity 2852 2874 +22
============================================
Files 288 290 +2
Lines 17818 18070 +252
Branches 2420 2468 +48
============================================
+ Hits 14989 15233 +244
Misses 1968 1968
- Partials 861 869 +8
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Feb 11, 2017
This was referenced Feb 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds specialized operators for merging
SingleandCompletablesources:Single.merge(Observable<Single<T>>)+maxConcurrencyoverloadSingle.mergeDelayError(Observable<Single<T>>)+maxConcurrencyoverloadObservable.flatMapSingle(Func1<T, Single<R>>)+delayErrors+delayErrors, maxConcurrencyoverloadsObservable.flatMapCompletable(Func1<T, Completable>)+delayErrors+delayErrors, maxConcurrencyoverloadsAll of these return
Observable.This replaces #4988.
Sidenote: for some time now, contributor(s) from certain party tend to contribute low quality or inadequate code and "disappear" pretty quickly. I can't be sure this is just lazyness or a deliberate and elaborate scheme to extract free work out of me for their own party's benefit but it is annoying as hell.