2.x: Correct marble diagram dimensions#5087
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Feb 9, 2017
PicnicSupermarket:bugfix/correct-marble-diagram-dimensions
Merged
2.x: Correct marble diagram dimensions#5087akarnokd merged 1 commit intoReactiveX:2.xfrom PicnicSupermarket:bugfix/correct-marble-diagram-dimensions
akarnokd merged 1 commit intoReactiveX:2.xfrom
PicnicSupermarket:bugfix/correct-marble-diagram-dimensions
Conversation
This fixes part of #4535. These changes were generated using the following script: ```sh #!/usr/bin/env bash find . -name '*.java' -print0 \ | xargs -0 grep '^\s*\*' \ | grep -oP 'https.*?\.png' \ | sort -u \ | while read -r I; do echo "Updating ${I}..." # Gather image details. DATA="$(identify <(curl -f -L -s "${I}"))" # Extract the image's true width and height. WIDTH="$(echo "${DATA}" | grep -oP '(?<=PNG )\d+')" HEIGHT="$(echo "${DATA}" | grep -oP 'PNG \d+x\d+' | grep -oP '(?<=x)\d+')" # Determine the image's scaled height, assuming a width of 640 pixels. NEW_HEIGHT="$(echo 'scale=100; s='"${WIDTH}"' / 640; scale=0; '"${HEIGHT}"' / s' | bc)" # Update all `<img/>` tags referencing the image. find . -name '*.java' -print0 \ | xargs -0 perl -i -p -e 's,<img( (width|height)="[^"]*")* src="\Q'"${I}"'\E",<img width="640" height="'"${NEW_HEIGHT}"'" src="'"${I}"'",g' done ```
Contributor
Author
|
(Note that I assumed that it's okay to just fix the width of all images at 640px; that seemed to be the prevailing style.) |
Member
|
Great scripting job! |
Contributor
Author
|
Thanks! :). Since the change only touches JavaDoc, I assume the Travis CI job failure is spurious/unrelated? Otherwise I'll need a pointer on how to correct the situation. |
Member
|
The failure is due to time sensitive tests failing on an overloaded CI. I'll try to resolve it separately, don't worry about it. |
Codecov Report@@ Coverage Diff @@
## 2.x #5087 +/- ##
============================================
+ Coverage 95.51% 95.59% +0.07%
- Complexity 5547 5550 +3
============================================
Files 614 614
Lines 39580 39580
Branches 5559 5559
============================================
+ Hits 37805 37836 +31
+ Misses 778 758 -20
+ Partials 997 986 -11
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes part of #4535, as requested in #5067.
These changes were generated using the following script: