use bounded wildcards for errorHandler (fixes #5045)#5049
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom Feb 3, 2017
Merged
use bounded wildcards for errorHandler (fixes #5045)#5049akarnokd merged 2 commits intoReactiveX:2.xfrom
akarnokd merged 2 commits intoReactiveX:2.xfrom
Conversation
Codecov Report@@ Coverage Diff @@
## 2.x #5049 +/- ##
============================================
+ Coverage 95.53% 95.65% +0.12%
- Complexity 5540 5547 +7
============================================
Files 612 612
Lines 39576 39576
Branches 5553 5553
============================================
+ Hits 37807 37855 +48
+ Misses 775 742 -33
+ Partials 994 979 -15
Continue to review full report at Codecov.
|
Member
|
/cc @davidmoten |
Collaborator
|
yep that looks fine. I can do the others. |
Collaborator
|
@akarnokd do you want test coverage of the signature changes? |
Member
|
Yes, make sure the contravariant consumer now compiles. |
Collaborator
|
@jschneider can you add unit tests for this please? |
Contributor
Author
|
I will add a test. Yes. |
Contributor
Author
|
Added the test |
Member
|
Looks like this got a conflict due to changes to RxJavaPlugins by other PRs. Could you rebase this onto the head? |
f887652 to
d677bfc
Compare
Contributor
Author
|
yep. I am on it |
Contributor
Author
|
should be good now. |
akarnokd
approved these changes
Feb 3, 2017
| @Test | ||
| public void onErrorWithSuper() throws Exception { | ||
| try { | ||
| Consumer<? super Throwable> errorHandler = new Consumer<Throwable>() { |
Member
There was a problem hiding this comment.
A better type would be Consumer<Object> errorHandler = ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding bound wildcards for error handler - fixes #5045