2.x: Update marble diagrams for sample overloads#4990
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom Jan 16, 2017
Merged
2.x: Update marble diagrams for sample overloads#4990akarnokd merged 2 commits intoReactiveX:2.xfrom
akarnokd merged 2 commits intoReactiveX:2.xfrom
Conversation
Current coverage is 95.48% (diff: 100%)@@ 2.x #4990 diff @@
==========================================
Files 592 592
Lines 37969 37969
Methods 0 0
Messages 0 0
Branches 5752 5752
==========================================
- Hits 36273 36256 -17
- Misses 741 753 +12
- Partials 955 960 +5
|
Member
Author
Collaborator
Member
Author
|
Those tail symbols look odd to me and look easy to miss or categorize as diagram errors. |
This was referenced Jan 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR updates the referenced marble diagrams to reflect the actual behavior and options with
sample.New images:
sample(time, emitLast)sample(time, scheduler, emitLast)sample(other)- the original image indicated the emission of the last item which was not the casesample(other, emitLast)