2.x: fix publish(Function) not replenishing its queue#4943
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Dec 29, 2016
Merged
2.x: fix publish(Function) not replenishing its queue#4943akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Current coverage is 95.50% (diff: 100%)@@ 2.x #4943 diff @@
==========================================
Files 587 587
Lines 37540 37549 +9
Methods 0 0
Messages 0 0
Branches 5652 5655 +3
==========================================
- Hits 35896 35863 -33
- Misses 694 723 +29
- Partials 950 963 +13
|
This was referenced Dec 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on converting the Monte Carlo PI benchmark to RxJava 2 and it turned out I forgot to replenish the internal queue of
publish(Function)in case the upstream was not sync-fuseable.This PR fixes the replenishment problem for non-fused and async-fused sources by requesting after 75% consumption.
In addition, if an inner subscriber cancelled while it was at request 0, the other inner subscribers might not have resumed draining.
I've also fixed two unit tests with wrong timeout unit of measure that randomly failed the tests on a slow machine or travis (#4902).