2.x: Change Completable to CompletableSource#4924
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Dec 16, 2016
vanniktech:2.x_completablesource
Merged
2.x: Change Completable to CompletableSource#4924akarnokd merged 1 commit intoReactiveX:2.xfrom vanniktech:2.x_completablesource
akarnokd merged 1 commit intoReactiveX:2.xfrom
vanniktech:2.x_completablesource
Conversation
akarnokd
approved these changes
Dec 16, 2016
Current coverage is 95.58% (diff: 100%)@@ 2.x #4924 diff @@
==========================================
Files 586 586
Lines 37446 37446
Methods 0 0
Messages 0 0
Branches 5625 5625
==========================================
- Hits 35823 35792 -31
- Misses 683 698 +15
- Partials 940 956 +16
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
CompletabletoCompletableSource. Also found one other wrong spot that I fixed within this PR.Fixes #4923