Skip to content

Use t instead of value to allow for IDE naming 1.x #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akarnokd merged 1 commit into from
Dec 7, 2016
Merged

Use t instead of value to allow for IDE naming 1.x #4908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/rx/SingleSubscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ public abstract class SingleSubscriber<T> implements Subscription {
* <p>
* The {@link Single} will not call this method if it calls {@link #onError}.
*
* @param value
* @param t
* the item emitted by the Single
*/
public abstract void onSuccess(T value);
public abstract void onSuccess(T t);

/**
* Notifies the SingleSubscriber that the {@link Single} has experienced an error condition.
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/rx/observers/SafeSubscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,14 @@ public void onError(Throwable e) {
* The {@code Observable} will not call this method again after it calls either {@link #onCompleted} or
* {@link #onError}.
*
* @param args
* @param t
* the item emitted by the Observable
*/
@Override
public void onNext(T args) {
public void onNext(T t) {
try {
if (!done) {
actual.onNext(args);
actual.onNext(t);
}
} catch (Throwable e) {
// we handle here instead of another method so we don't add stacks to the frame
Expand Down