Use t instead of value to allow for IDE naming#4907
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Dec 7, 2016
Jawnnypoo:named-values
Merged
Use t instead of value to allow for IDE naming#4907akarnokd merged 1 commit intoReactiveX:2.xfrom Jawnnypoo:named-values
akarnokd merged 1 commit intoReactiveX:2.xfrom
Jawnnypoo:named-values
Conversation
JakeWharton
approved these changes
Dec 7, 2016
Contributor
JakeWharton
left a comment
There was a problem hiding this comment.
Awesome. Does 2.x need this?
Contributor
Author
|
This is for 2.X. Did I make a mistake? I could add this to 1.X also if desired. |
Contributor
|
Hah, yeah I meant 1.x. Off-by-one error. |
Contributor
Author
|
#4908 Surprisingly it was already done a lot more in 1.x, so there were only a few cases I found. |
Current coverage is 95.70% (diff: 100%)@@ 2.x #4907 diff @@
==========================================
Files 586 586
Lines 37410 37410
Methods 0 0
Messages 0 0
Branches 5628 5628
==========================================
+ Hits 35792 35803 +11
+ Misses 673 665 -8
+ Partials 945 942 -3
|
akarnokd
approved these changes
Dec 7, 2016
mariusc83
pushed a commit
to mariusc83/RxJava
that referenced
this pull request
Mar 17, 2017
mariusc83
pushed a commit
to mariusc83/RxJava
that referenced
this pull request
Mar 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming the value
tinstead ofvalueallows the IntelliJ to intelligently name the variable based on the type when autocompleting.Before:
After: