1.x: enable TestScheduler with nanosecond periodic scheduling#4884
Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom Nov 28, 2016
Merged
1.x: enable TestScheduler with nanosecond periodic scheduling#4884akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd merged 1 commit intoReactiveX:1.xfrom
Conversation
Current coverage is 84.21% (diff: 93.10%)@@ 1.x #4884 diff @@
==========================================
Files 287 288 +1
Lines 17803 17808 +5
Methods 0 0
Messages 0 0
Branches 2696 2698 +2
==========================================
- Hits 15000 14997 -3
- Misses 1952 1960 +8
Partials 851 851
|
artem-zinnatullin
approved these changes
Nov 25, 2016
|
|
||
| @Test | ||
| public void resolution() { | ||
| for (final TimeUnit unit : TimeUnit.values()) { |
This was referenced Dec 5, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default periodic scheduling code accessed the current worker time as milliseconds which prevents running microsecond and nanosecond scale unit tests with TestScheduler as its internal nanosecond resolution time is always converted, losing precision.
This PR introduces the internal
SchedulePeriodicHelperclass, moves the default scheduling code into a static method and defines aNowNanoSupplierinterface that is now implemented by TestSchedulerWorker to return the current nano time. The defaultWorker.schedulePeriodicallydelegates to this static method and given anullnoNanoSuppliertheWorker.now()is converted to nanoseconds as usual.Related: #4883