2.x: add doFinally for handling post-terminal or cancel cleanup#4831
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Nov 10, 2016
Merged
2.x: add doFinally for handling post-terminal or cancel cleanup#4831akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Current coverage is 95.82% (diff: 96.93%)@@ 2.x #4831 diff @@
==========================================
Files 570 571 +1
Lines 36723 36821 +98
Methods 0 0
Messages 0 0
Branches 5556 5571 +15
==========================================
+ Hits 35143 35284 +141
+ Misses 651 626 -25
+ Partials 929 911 -18
|
JakeWharton
approved these changes
Nov 10, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
Flowable.doFinallymethod that executes an action when the upstream terminates or the downstream cancels (but only once per subscriber). Formerly, one could usedoAfterTerminate+doOnCanceltogether but no support for making sure only one executed the cleanup action.Based on the feedback, the rest of the base reactive types can get the same operator a bit later.