2.x: fix Observable.repeatWhen & retryWhen not disposing the inner#4783
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Oct 31, 2016
Merged
2.x: fix Observable.repeatWhen & retryWhen not disposing the inner#4783akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Current coverage is 95.72% (diff: 91.66%)@@ 2.x #4783 diff @@
==========================================
Files 570 570
Lines 36713 36717 +4
Methods 0 0
Messages 0 0
Branches 5555 5554 -1
==========================================
- Hits 35200 35149 -51
- Misses 617 646 +29
- Partials 896 922 +26
|
JakeWharton
approved these changes
Oct 31, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Observerthat is subscribing to theObservablereturned by the handler function was not properly linked to the disposing of the end Observer. This PR fixes it by making thatObserverdo asyncDisposablemanagement and make sure the endObserverreceives a disposable list with both the main and the handlerDisposables.The
Flowableversions worked properly but added unit tests to them regardless.Reported in #4782.