Skip to content

2.x: cleanup, fixes and coverage 10/25#4766

Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd:Coverage_10_25_1
Oct 25, 2016
Merged

2.x: cleanup, fixes and coverage 10/25#4766
akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd:Coverage_10_25_1

Conversation

@akarnokd
Copy link
Member

This is the last part of my dedicated coverage improvement run.

  • Update code paths and remove unnecessary and unused parts.
  • Fix skipUntil lifecycle and concurrency properties.
  • Fix concatMapEager error management.
  • Flowable.scan(T, BiFunction) now emits the initial value only when the upstream signals an event. This has the effect that even if there is a downstream request, the initial value won't get emitted. This change reduces the overhead of the operator greatly.

@codecov-io
Copy link

Current coverage is 95.66% (diff: 92.12%)

Merging #4766 into 2.x will increase coverage by 0.26%

@@                2.x      #4766   diff @@
==========================================
  Files           570        570          
  Lines         36784      36711    -73   
  Methods           0          0          
  Messages          0          0          
  Branches       5570       5555    -15   
==========================================
+ Hits          35094      35120    +26   
+ Misses          735        662    -73   
+ Partials        955        929    -26   

Powered by Codecov. Last update 318bf43...084725c

@akarnokd akarnokd merged commit 83ba4b9 into ReactiveX:2.x Oct 25, 2016
@akarnokd akarnokd deleted the Coverage_10_25_1 branch October 25, 2016 14:44
@akarnokd akarnokd mentioned this pull request Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants