2.x: coverage, fixes, enhancements, cleanup 10/18-1#4723
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Oct 18, 2016
Merged
2.x: coverage, fixes, enhancements, cleanup 10/18-1#4723akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Current coverage is 90.00% (diff: 96.07%)@@ 2.x #4723 diff @@
==========================================
Files 570 571 +1
Lines 37234 37241 +7
Methods 0 0
Messages 0 0
Branches 5672 5671 -1
==========================================
+ Hits 33205 33518 +313
+ Misses 2439 2236 -203
+ Partials 1590 1487 -103
|
JakeWharton
approved these changes
Oct 18, 2016
This was referenced Oct 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObservableoperatorsConnectableObservable.connect(Consumer)andConnectableFlowable.connect(Consumer)Observable.observeOnObservable.justflatMapIterable(Function, int)overload and haveflatMapIterable(Function)use the flatten operator.Observable.replay()potential emission beforeonSubscribecall