2.x: Remove checked exceptions from transformer interfaces.#4710
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Oct 19, 2016
JakeWharton:jw/check-checked-transformers
Merged
2.x: Remove checked exceptions from transformer interfaces.#4710akarnokd merged 1 commit intoReactiveX:2.xfrom JakeWharton:jw/check-checked-transformers
akarnokd merged 1 commit intoReactiveX:2.xfrom
JakeWharton:jw/check-checked-transformers
Conversation
These functions are for transforming the stream shape, not doing work. Any operation that would throw a checked exception should happen inside the stream, not when shaping it.
Current coverage is 87.14% (diff: 100%)@@ 2.x #4710 diff @@
==========================================
Files 568 568
Lines 37061 37046 -15
Methods 0 0
Messages 0 0
Branches 5648 5648
==========================================
- Hits 32312 32283 -29
- Misses 3050 3062 +12
- Partials 1699 1701 +2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are for transforming the stream shape, not doing work. Any operation that would throw a checked exception should happen inside the stream, not when shaping it.
Closes #4709.