Skip to content

2.x: coverage, fixes and cleanup 10/11-2#4692

Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd:Coverage10_11_2
Oct 12, 2016
Merged

2.x: coverage, fixes and cleanup 10/11-2#4692
akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd:Coverage10_11_2

Conversation

@akarnokd
Copy link
Member

  • cover remaining Maybe operators
  • cover Single operators
  • cover some of the Completable operators
  • fix missing onSubscribe calls
  • compact a few operator implementations
  • fix the order of inner Throwables on certain CompositeException emissions

@codecov-io
Copy link

codecov-io commented Oct 12, 2016

Current coverage is 83.53% (diff: 98.17%)

Merging #4692 into 2.x will increase coverage by 0.67%

@@                2.x      #4692   diff @@
==========================================
  Files           566        567     +1   
  Lines         37564      37618    +54   
  Methods           0          0          
  Messages          0          0          
  Branches       5782       5790     +8   
==========================================
+ Hits          31124      31423   +299   
+ Misses         4406       4196   -210   
+ Partials       2034       1999    -35   

Powered by Codecov. Last update 6ad74b3...7421090

Copy link
Contributor

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one took a while!

@akarnokd
Copy link
Member Author

It was sitting in the Travis job queue.

@akarnokd akarnokd merged commit a2cb6ab into ReactiveX:2.x Oct 12, 2016
@akarnokd akarnokd deleted the Coverage10_11_2 branch October 12, 2016 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants