2.x: coverage and cleanup 10/11-1#4689
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Oct 11, 2016
Merged
Conversation
Current coverage is 82.85% (diff: 98.24%)@@ 2.x #4689 diff @@
==========================================
Files 565 564 -1
Lines 37440 37401 -39
Methods 0 0
Messages 0 0
Branches 5746 5741 -5
==========================================
+ Hits 30753 30989 +236
+ Misses 4612 4394 -218
+ Partials 2075 2018 -57
|
JakeWharton
approved these changes
Oct 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the coverage of
Maybeoperators (run out of time for this batch, 5 remaining) and fixes an NPE bug inMaybe.doOnEventdue to not saving theDisposable. Some inner receivers no longer implementDisposableasisDisposedis unreachable and not really necessary.In addition
Maybe.toCompletablewas removed in favor ofMaybe.ignoreElement().