2.x: Add Completable.andThen(MaybeSource)#4616
Merged
akarnokd merged 3 commits intoReactiveX:2.xfrom Sep 27, 2016
vanniktech:2.x_completable_and_then_maybe
Merged
2.x: Add Completable.andThen(MaybeSource)#4616akarnokd merged 3 commits intoReactiveX:2.xfrom vanniktech:2.x_completable_and_then_maybe
akarnokd merged 3 commits intoReactiveX:2.xfrom
vanniktech:2.x_completable_and_then_maybe
Conversation
Member
|
There is a compilation error. |
Collaborator
Author
|
Ah yes import is missing. I still manually stage them and sometimes forget that one is needed since usually every package is already included with |
akarnokd
requested changes
Sep 27, 2016
|
|
||
| @Override | ||
| public void onSubscribe(Disposable d) { | ||
| if (DisposableHelper.set(this, d)) { |
Collaborator
Author
There was a problem hiding this comment.
Then this would need to be changed too, right?
akarnokd
approved these changes
Sep 27, 2016
Current coverage is 78.18% (diff: 85.71%)@@ 2.x #4616 diff @@
==========================================
Files 553 554 +1
Lines 36128 36162 +34
Methods 0 0
Messages 0 0
Branches 5559 5560 +1
==========================================
+ Hits 28231 28272 +41
+ Misses 5891 5882 -9
- Partials 2006 2008 +2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.