2.x: Report errors from onError to Plugin when done#4590
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Sep 23, 2016
vanniktech:2.x_report_errors_to_plugin
Merged
2.x: Report errors from onError to Plugin when done#4590akarnokd merged 1 commit intoReactiveX:2.xfrom vanniktech:2.x_report_errors_to_plugin
akarnokd merged 1 commit intoReactiveX:2.xfrom
vanniktech:2.x_report_errors_to_plugin
Conversation
Current coverage is 78.14% (diff: 45.45%)@@ 2.x #4590 diff @@
==========================================
Files 552 552
Lines 36220 36247 +27
Methods 0 0
Messages 0 0
Branches 5594 5594
==========================================
+ Hits 28282 28326 +44
+ Misses 5927 5914 -13
+ Partials 2011 2007 -4
|
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the first one that I found I even wrote a test. Then I started noticing more missing spots. If wanted I could port that one test to every operator that I touched. Though I didn't really find tests testing that errors are propagated through the Plugin API.