Skip to content

2.x: fixes, cleanup, coverage 8/31-1#4450

Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd:CleanupFixes831
Aug 31, 2016
Merged

2.x: fixes, cleanup, coverage 8/31-1#4450
akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd:CleanupFixes831

Conversation

@akarnokd
Copy link
Member

  • Improve coverage of internal classes
  • Turn more empty enums into classes with private constructors
  • Fix Single.subscribeOn and Completable.subscribeOn disposable management.
  • Create a compact FutureSubscriber and FutureObserver classes, drop their former enums
  • Deprecate Disposables.from methods, add Disposables.fromX methods where X = argument type
  • Fix error management in Completable.mergeX operators.
  • Remove unused methods from internal classes

@codecov-io
Copy link

codecov-io commented Aug 31, 2016

Current coverage is 75.82% (diff: 69.75%)

Merging #4450 into 2.x will increase coverage by 0.46%

@@                2.x      #4450   diff @@
==========================================
  Files           454        454          
  Lines         32274      32200    -74   
  Methods           0          0          
  Messages          0          0          
  Branches       5209       5178    -31   
==========================================
+ Hits          24322      24417    +95   
+ Misses         5914       5769   -145   
+ Partials       2038       2014    -24   

Powered by Codecov. Last update 81badc3...0c30b08

*/
public final Future<T> toFuture() {
return FlowableToFuture.toFuture(this);
return subscribeWith(new FutureSubscriber<T>());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool trick!

@JakeWharton
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants