1.x: observeOn + immediate scheduler to be a request rebatcher#3964
Closed
akarnokd wants to merge 1 commit intoReactiveX:1.xfrom
Closed
1.x: observeOn + immediate scheduler to be a request rebatcher#3964akarnokd wants to merge 1 commit intoReactiveX:1.xfrom
akarnokd wants to merge 1 commit intoReactiveX:1.xfrom
Conversation
Collaborator
|
Great! What about adding a method to |
Member
Author
|
That could be a follow-up PR if this gets accepted. |
Member
|
Why not just adding a Secondly, using |
Member
Author
|
The alternative requires duplicating code, which triggers more outcry usually... |
Member
|
I think you can add a flag (e.g., disallowOptimization) to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
immediate()scheduler "optimization" fromobserveOnand treats it as a common scheduler. SinceobserveOnhas a stable request pattern, this turns it into a rebatching operator. No matter what the downstream requests, the upstream will requests of the specified size (with 25% as low water mark; i.e., replenishment after 75%). Sinceimmediateis synchronous, this will run the drain loop, non-reentrant, on the caller thread.I found this mode of operation very handy in my Reactive-RPC prototype and a simple streaming echo RPC call; it prevents going unbounded and bloating the message sender threads: