Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/rx/internal/operators/OperatorMerge.java
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ protected void queueScalar(T value) {
}
this.queue = q;
}
if (!q.offer(value)) {
if (!q.offer(nl.next(value))) {
unsubscribe();
onError(OnErrorThrowable.addValueAsLastCause(new MissingBackpressureException(), value));
return;
Expand Down
21 changes: 19 additions & 2 deletions src/test/java/rx/internal/operators/OperatorMergeTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@
import org.mockito.*;

import rx.*;
import rx.Observable.OnSubscribe;
import rx.Scheduler.Worker;
import rx.Observable;
import rx.Observable.OnSubscribe;
import rx.Observer;
import rx.Scheduler.Worker;
import rx.functions.*;
import rx.internal.util.RxRingBuffer;
import rx.observers.TestSubscriber;
Expand Down Expand Up @@ -1353,4 +1353,21 @@ public void zeroMaxConcurrent() {
assertEquals("maxConcurrent > 0 required but it was 0", e.getMessage());
}
}

@Test
public void mergeJustNull() {
TestSubscriber<Integer> ts = new TestSubscriber<Integer>(0);

Observable.range(1, 2).flatMap(new Func1<Integer, Observable<Integer>>() {
@Override
public Observable<Integer> call(Integer t) {
return Observable.just(null);
}
}).subscribe(ts);

ts.requestMore(2);
ts.assertValues(null, null);
ts.assertNoErrors();
ts.assertCompleted();
}
}