1.x: Deprecate CompositeException constructor with message prefix

[vanniktech]

Before this PR messagePrefix was never used 💃

If you guys want I can revert the change on CompositeExceptionTest.java:177. I just thought that way it' be nicer.

About the message is there any reason for having a space after the dot?

[akarnokd]

We don't really use that constructor or the message, so I'd prefer removing it altogether.

[vanniktech]

Yeah I also realized that later since no test broke after that change. So do you want me to remove it?

[akarnokd]

Yes, but don't rush it as there is another, much heavier PR #3759 that also changed this class.

[vanniktech]

Alright just ping me once #3759 is in

[vanniktech]

@akarnokd I updated the PR again and changed the commit message and the title. I hope the changes are okay now. If the removal of whitespace bugs you just let me know.

[akarnokd]

Yes, please revert those space changes. (Are you using IntelliJ?)

[vanniktech]

Those changes I did in Sublime and I set it up in a way that it should remove trailing whitespace ;)

Also updated the PR and removed the spaces

[akarnokd]

Almost, but forgot that its a public API component thus can't just remove the constructors. Could you instead deprecate CompositeException(String message, List<Throwable> errors)?

[vanniktech]

@akarnokd like this?

[akarnokd]

Yes.

👍

[artem-zinnatullin]

👍

[stevegury]

👍