Skip to content

1.x: onErrorResumeNext(Func1) should not call plugin handler there#3685

Closed
akarnokd wants to merge 1 commit intoReactiveX:1.xfrom
akarnokd:PublinErrorHandlerCallFix1x
Closed

1.x: onErrorResumeNext(Func1) should not call plugin handler there#3685
akarnokd wants to merge 1 commit intoReactiveX:1.xfrom
akarnokd:PublinErrorHandlerCallFix1x

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Feb 9, 2016

When the operator switches to the other, that counts as a handled error.

See also #3347.

@benkomalo
Copy link

There are similar patterns in the other onError* operators, namely OperatorOnErrorResumeNextViaObservable and OperatorOnErrorReturn - do those need changing as well?

@akarnokd
Copy link
Member Author

akarnokd commented Feb 9, 2016

Yes, I'll update this PR.

@akarnokd akarnokd force-pushed the PublinErrorHandlerCallFix1x branch from 8979a5e to 0871af0 Compare February 9, 2016 17:38
@akarnokd
Copy link
Member Author

akarnokd commented Feb 9, 2016

Updated, although all of these classes have backpressure bugs in them.

@akarnokd
Copy link
Member Author

akarnokd commented Feb 9, 2016

Replaced by #3689

@akarnokd akarnokd closed this Feb 9, 2016
@akarnokd akarnokd deleted the PublinErrorHandlerCallFix1x branch March 14, 2016 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants