1.x: fix SyncOnSubscribe not signalling onError if the generator crashes

[akarnokd]

Discovered in a stackoverflow question.

[artem-zinnatullin]

Can you test that too?

[akarnokd]

Not really, this exception has nowhere to go and hijacking the plugins is a nightmare.

[artem-zinnatullin]

That's sad, would be nice to have a way to test such cases.

On Tue, 26 Jan 2016, 00:44 David Karnok notifications@github.com wrote:

In src/main/java/rx/observables/SyncOnSubscribe.java
#3644 (comment):

@@ -363,7 +373,12 @@ private boolean tryUnsubscribe() {
}

     private void doUnsubscribe() {

•        parent.onUnsubscribe(state);
  

•        try {
  

•            parent.onUnsubscribe(state);
  

•        } catch (Throwable e) {
  

Not really, this exception has nowhere to go and hijacking the plugins is
a nightmare.

—
Reply to this email directly or view it on GitHub
https://github.com/ReactiveX/RxJava/pull/3644/files#r50760936.

@artem_zin

[artem-zinnatullin]

👍

[stealthcode]

👍

[akarnokd]

@stealthcode Do you have time to review #3631, see what else can be included into 1.1.1 and hopefully release it this week?

[stealthcode]

Sure I'll see what we can do.