Fix vararg issues reported in https://github.com/Netflix/RxJava/issues/359#361
Merged
benjchristensen merged 7 commits intoReactiveX:masterfrom Sep 10, 2013
Merged
Conversation
ReactiveX#359 Varargs cause compiler warnings
ReactiveX#359 Varargs cause compiler warnings As part of this I also changed this: ```java public static <T> Observable<T> concat(Observable<Observable<? extends T>> observables) ``` to ```java public static <T> Observable<T> concat(Observable<Observable<T>> observables) ``` I documented the reasoning of this at ReactiveX#360 (comment)
ReactiveX#359 Varargs cause compiler warnings
ReactiveX#359 Varargs cause compiler warnings
ReactiveX#359 Varargs cause compiler warnings
|
RxJava-pull-requests #253 SUCCESS |
Member
Author
|
This seems to be working well so am merging it. This removes all vararg usage. It does increase surface area with multiple-arity overloads, but it's clean and displays well in an IDE. I have chosen to use |
benjchristensen
added a commit
that referenced
this pull request
Sep 10, 2013
Fix vararg issues reported in #359
Closed
|
RxJava-pull-requests #254 SUCCESS |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Fix vararg issues reported in ReactiveX#359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch working on #359
I'll continue committing to this until all the varargs are replaced.