Skip to content

Implemented Observable#toCompletable#3567

Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom
stealthcode:ToCompletable
Dec 9, 2015
Merged

Implemented Observable#toCompletable#3567
akarnokd merged 1 commit intoReactiveX:1.xfrom
stealthcode:ToCompletable

Conversation

@stealthcode
Copy link

No description provided.

@stealthcode
Copy link
Author

Addresses part of #3443

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no items involved with Completable.

@akarnokd
Copy link
Member

akarnokd commented Dec 9, 2015

rx.internal.operators.OnSubscribeCompletableTest > testShouldUseUnsafeSubscribeInternallyNotSubscribe FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:92)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.junit.Assert.assertFalse(Assert.java:68)
        at org.junit.Assert.assertFalse(Assert.java:79)
        at rx.internal.operators.OnSubscribeCompletableTest.testShouldUseUnsafeSubscribeInternallyNotSubscribe(OnSubscribeCompletableTest.java:96)

The Completable.fromObservable needs to change to unsafeSubscribe.

@stealthcode
Copy link
Author

Thanks @akarnokd

@akarnokd
Copy link
Member

akarnokd commented Dec 9, 2015

👍

akarnokd added a commit that referenced this pull request Dec 9, 2015
Implemented Observable#toCompletable
@akarnokd akarnokd merged commit 0c039ee into ReactiveX:1.x Dec 9, 2015
@stevegury
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants