SerialSubscription and SingleAssignementSubscription naming, Subscriptions in general

[headinthebox]

SerialSubscription has

private static final Subscription UNSUBSCRIBED = new Subscription() {

SingleAssignmentSubscription has

private static final Subscription SENTINEL = new Subscription() {

for the same purpose.

Also, these use lockfree implementations, the other subscriptions use locks.

Perhaps someone can go over all subscriptions and implement them in the same style and using the same naming conventions.

[akarnokd]

I have to rebase my Subscription changes anyway, so I'll do the renaming to UNSUBSCRIBED_SENTINEL.

[jloisel]

I may help again to use lock free strategy in other subscription implementations.

[headinthebox]

@akarnod

You should be able to have serialsubscription inherit from multipleassignmentsubscription. The difference is that the latter unsubscribes when swapping in a new subscription. I think that would show the intent better and make the code more maintanable.

In fact, I think MultipleAssignmentSubscription itself can inherit from BooleanSubscription.

[akarnokd]

I don't know. I can create many PRs for all kinds of variants, but at the end @benjchristensen has to decide; I'd rather avoid look-and-feel development.