2.x Should observer be disposed after the source observable has finished emitting items?

[VictorAlbertos]

With 1.x this test pass:

@Test
  public void subscriberShouldBeUnsubscribed() {
    rx.observers.TestSubscriber subscriber = new rx.observers.TestSubscriber();
    rx.Observable.just("").subscribe(subscriber);
    subscriber.awaitTerminalEvent();

    subscriber.assertNoErrors();
    subscriber.assertCompleted();
    subscriber.assertUnsubscribed();
  }

But with 2.x this test does not pass:

  @Test
  public void observerShouldBeDisposed()  {
    TestObserver observer = new TestObserver();
    Observable.just("").subscribe(observer);
    observer.awaitTerminalEvent();

    observer.assertNoErrors();
    observer.assertComplete();
    assertThat(observer.isDisposed(), is(true));
  }

I think that dispose is similar to unsubscribe (but maybe I'm wrong). So I was wondering if this is the expected behaviour.

Thanks.

[akarnokd]

It's a small inconsistency. I'll fix that in my next cleanup/coverage PR.

[akarnokd]

Closing via 1145819

[maksim-m]

@akarnokd, with RxJava 2.0.7 the test still fails:

    @Test
    public void observerShouldBeDisposed()  {
        TestObserver observer = new TestObserver();
        Observable.just("").subscribe(observer);
        observer.awaitTerminalEvent();

        observer.assertNoErrors();
        observer.assertComplete();
        assertTrue(observer.isDisposed());
    }

[akarnokd]

There was a problem with that change and has been reverted in #4873.