fix(ubuntu): chown more safely#412
Closed
mikehardy wants to merge 1 commit intoReactiveCircus:mainfrom
mikehardy:chown-safely
Closed
fix(ubuntu): chown more safely#412mikehardy wants to merge 1 commit intoReactiveCircus:mainfrom mikehardy:chown-safely
mikehardy wants to merge 1 commit intoReactiveCircus:mainfrom
mikehardy:chown-safely
Conversation
Contributor
mikehardy
commented
Oct 11, 2024
- make sure the root of android stuff is chowned for installation of completely new things if needed
- don't fail when recursively chowning specific android things, as they may not exist yet (i.e., platform-tools) when chown is attempted
- make sure the root of android stuff is owned for modification - don't fail when recursively chowning specific android things, as they may not exist yet (i.e., platform-tools) when chown is attempted
Contributor
Author
|
This can be considered a follow-on to #406 - which is a nice performance boost but makes assumptions about the directories existing - linux will throw a non-zero exit code if you chown something that isn't there but using a |
Contributor
Author
|
chown not required at all anymore it seems - less code == better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.