1,3 Insertion CO2 rxns#584
Merged
Merged
Conversation
Contributor
|
@kspieks Thanks. The commits about the CO2 insertion family look good. I assume the commits about Diels Alder is due to the branch being out-dated? Please rebase the commit, and I will merge this PR afterward. |
Contributor
Author
|
@xiaoruiDong Thanks for reviewing! Yes the branch was out of date. Sorry for the confusion. Upon rebasing, those first 3 commits should be removed since we already merged them in PR #582. |
6dc534d to
45dd9de
Compare
xiaoruiDong
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 3 training reactions for the 1,3 Insertion CO2 family. All species are calculated at
CCSD(T)-F12a/cc-pVDZ-F12//ωB97X-D3/def2-TZVP. A thorough conformer search was done on the reactant, TS, and product. 1D rotor scans were also done on the reactant, TS, and product. All scans start and end in the same place and have the lowest energy well at 0 degrees, which makes sense since a conformer search was done for each species. The notebook below hasassert glog.successwhich was True for all species. Also included in the zip file is the notebook for running ATG to refit the rate rules.Note that the previous reaction template was redundant since it allowed *1 to be on either the C or the O in CO2. But if we swap *3 and *4, we can get the same product whether *1 is on C or O. Thus, this PR simplifies the root node so that the template actually matches the picture in the .eps file.
This PR should be merged after PR #582.
1,3_Insertion_CO2_notebooks.zip