Refit Intra R Add Endo/Exocyclic Rate Rules#570
Merged
Merged
Conversation
Contributor
Author
|
For completeness, I actually refit these reaction families when rebasing and pushing using a better list of thermo libraries. The list I used is This is the same lists that are given by default in our ATG notebook as well as our ATG script but I also appended my thermo libraries to the front which have very good calculations. I made a mistake the first time I pushed this branch in that I only used |
This library contains species participating in reactions relevant to heavy oil pyrolysis mechanisms
This value was previously estimated using group additivity. Now it is calculated with TST after doing conformer search and 1D rotor scans
amarkpayne
approved these changes
Apr 4, 2022
amarkpayne
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @kspieks ! I'll merge this in as soon as the tests pass
Contributor
|
Merged as both checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 1 training reaction to each of the
Intra_R_Add_EndocyclicandIntra_R_Add_Exocyclicreaction families and also refits the rate rules. All calculations were done atCCSD(T)-F12a/cc-pVDZ-F12//ωB97X-D3/def2-TZVPand include conformer searches and 1D rotor scans. The notebooks for refitting the rate rules as well as a slide deck that summarizes the improved rate estimate for these reactions is included in the zip file below.The training reaction added to
Intra_R_Add_Exocyclicbrings substantial improvements. Previously, the rate rules gave an estimate for k(T=673K) that was over 1000x smaller than the actual rate calculated from TST.The training reaction added to
Intra_R_Add_Endocyclicbrings minor improvements. Previously, this training reaction, which just came from group additivity, gave an estimate for k(T=673K) that was ~5x smaller than the actual rate calculated from TST. Note that since the product for this training reaction is chiral, the A-factor had to be multiplied by 2 since the reactant can attack itself from either the top or the bottom (both options are possible and equally likely).Hopefully these new training reactions and rate rules improve people's mechanisms :)
20220321.zip