Skip to content

updated DFT_QCI_thermo with uncertainty data from paper#49

Closed
nickvandewiele wants to merge 2 commits into
ReactionMechanismGenerator:masterfrom
nickvandewiele:DFT_QCI_Thermo_uncertainty
Closed

updated DFT_QCI_thermo with uncertainty data from paper#49
nickvandewiele wants to merge 2 commits into
ReactionMechanismGenerator:masterfrom
nickvandewiele:DFT_QCI_Thermo_uncertainty

Conversation

@nickvandewiele

Copy link
Copy Markdown
Contributor

also: updated indeces > 33 to comply with original indices of paper.

also: updated indeces > 33 to comply with original indices of paper.
@nickvandewiele

Copy link
Copy Markdown
Contributor Author

This pull request solves ReactionMechanismGenerator/RMG-Py#267

The script to do this can be re-used:
https://gist.github.com/d6823c65e8a6b16debc1

@rwest

rwest commented Aug 21, 2014

Copy link
Copy Markdown
Member

Looks good, thanks for doing this.
And I think the Travis failure is because of the new adjacency list parser not noticing the difference between O_atom_triplet and O_atom_singlet and is unrelated to this.

However, I do wonder what we should do about the uncertainties that are reported as zero. Presumably @cfgold calculated that they were less than 0.05 and he was reporting things to 1 decimal place so rounded to 0.0 instead of 0.1. However, if one day this gets used in some optimization or "consistent set" checking tool (as we saw many of at the Symposium), then an uncertainty of precisely zero will make the constraints hard to satisfy! Should we put 0.05?

@nickvandewiele

Copy link
Copy Markdown
Contributor Author

Agreed. I will update all 0.0s to 0.05s.

@connie connie closed this in 6d183b2 Nov 4, 2014
@alongd alongd mentioned this pull request Dec 30, 2015
JacksonBurns pushed a commit that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants